Add AM/PM style option for clock overlay (#7)#17
Open
brad wants to merge 1 commit into
Open
Conversation
- Added useAmPm to ConfigProvider and implemented it in JsonConfigService. - Added use_am_pm setting to assets/config.json. - Added localization strings for useAmPm in English and German. - Updated SettingsScreen to include a switch for AM/PM format under Clock settings. - Updated ClockOverlay to format time in 12-hour format when useAmPm is true. - Updated SlideshowScreen to pass the useAmPm setting to ClockOverlay. - Fixed missing concrete implementations of useAmPm in test mocks. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: brad <1614+brad@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used Jules to create this, please feel free voice any concerns and I'll do my best to fix them. There are nightly releases built by github actions in my clone if you wanna try
Preview